chore: use valueOf instead of deprecated boxing constructors in FlagTest - #392
Closed
abelonogov-ld wants to merge 1 commit into
Closed
chore: use valueOf instead of deprecated boxing constructors in FlagTest#392abelonogov-ld wants to merge 1 commit into
abelonogov-ld wants to merge 1 commit into
Conversation
The build compiles with -Xlint:deprecation, so these three calls print warnings on every run. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The build compiles with
-Xlint:deprecation, so threenew Integer(...)/new Long(...)calls inFlagTestprint warnings on every CI run:valueOfis the direct replacement. Overload resolution is unchanged — the arguments are still boxed types, so these remainassertEquals(Object, Object)calls comparing the same values.Test plan
FlagTestpassesNothing shipped changes, so this is
choreand should not cut a release.Note: CI on this branch may hit the
FDv2DataSourceTestflake until #390 merges, since this branch is on currentmain.Note
Overview
Test-only cleanup in
FlagTest: threeassertEqualsexpectations now useInteger.valueOf(2)andLong.valueOf(...)instead of deprecatednew Integer(...)/new Long(...), so-Xlint:deprecationno longer warns on those lines during CI.Behavior is unchanged—the same boxed values are compared via
assertEquals(Object, Object)overload resolution.Reviewed by Cursor Bugbot for commit 12a0505. Bugbot is set up for automated code reviews on this repo. Configure here.